snips-nlu icon indicating copy to clipboard operation
snips-nlu copied to clipboard

Quarter not understood if written as "Q1 2018"

Open joffreyvillard opened this issue 7 years ago • 1 comments

Hi! Quarters are not identified properly when written in short form:

"first quarter of 2018" > ok

{
      "entity": "snips/datetime",
      "range": {
        "end": 21,
        "start": 0
      },
      "rawValue": "first quarter of 2018",
      "slotName": "date-time",
      "value": {
        "grain": "Quarter",
        "kind": "InstantTime",
        "precision": "Exact",
        "value": "2018-01-01 00:00:00 +01:00"
      }
    }

"1st quarter of 2018" > ok

{
      "entity": "snips/datetime",
      "range": {
        "end": 19,
        "start": 0
      },
      "rawValue": "1st quarter of 2018",
      "slotName": "date-time",
      "value": {
        "grain": "Quarter",
        "kind": "InstantTime",
        "precision": "Exact",
        "value": "2018-01-01 00:00:00 +01:00"
      }
    }

"Q1 2018" > not ok

{
      "entity": "snips/datetime",
      "range": {
        "end": 7,
        "start": 3
      },
      "rawValue": "2018",
      "slotName": "date-time",
      "value": {
        "grain": "Year",
        "kind": "InstantTime",
        "precision": "Exact",
        "value": "2018-01-01 00:00:00 +01:00"
      }
    }

Best, Joffrey

joffreyvillard avatar Oct 12 '18 10:10 joffreyvillard

Hey, thanks for the feedback, It is a reasonable use case indeed. We will add the support for it as soon as we can. It shouldn't be too hard.

Best, Adrien

adrienball avatar Oct 12 '18 10:10 adrienball