snips-issues icon indicating copy to clipboard operation
snips-issues copied to clipboard

[Injection] Let application to be aware of injection end/success/fail

Open deniseBrise opened this issue 6 years ago • 2 comments

Is your feature request related to a problem? Please describe. My request is related to problem : Injection fail when JSON contains empty value #192 It would be intersting to know when an injection is in progress (or finished). Currently we can rely on message "hermes/asr/reload" or "hermes/nlu/reload" when injection is successful, but nothing happen on fail.

What are the use cases of this feature Let application to be aware of injection end/success/fail.

Describe the solution you'd like Adding messages with injection end/success/fail information would be appreciable.

Describe alternatives you've considered Relying on "hermes/asr/reload" or "hermes/nlu/reload" messages in case of success.

Additional context

deniseBrise avatar Sep 11 '19 13:09 deniseBrise

Hi @deniseBrise,

Injection complete will be available in the next release. Failure info is planned for the one after.

You'll be updated on this ticket when those feature are available.

Thanks again for your feedbacks

cpoisson avatar Sep 12 '19 16:09 cpoisson

Partially fixed in version 1.3.0

If the injection fail, the completion message will not be emitted.

cpoisson avatar Oct 02 '19 14:10 cpoisson