snips-issues
snips-issues copied to clipboard
To install an assistant, sam runs `bash -c 'sh setup.sh'` - which breaks venv
What's the issue?
Venv activation requires to be run in bash to work, but sam runs bash -c 'sh setup.py'
and sh is a symlink to dash on a lot of systems (ubuntu and newer raspbians at least) and that breaks venv activation.
Use Cases Impacted
Assistant install and update
How to reproduce
Run sam install assistant
to a system with dash as sh
Expected behavior
Should install the assistant without errors
Version and Environment 0.63.3 / Lubuntu 19.04
Additional information
Workaround
Symlinking sh -> bash fixes this or just editing /usr/local/lib/node_modules/snips-sam/lib/session/ssh.js
to simply run setup with bash directly.