snipe-it icon indicating copy to clipboard operation
snipe-it copied to clipboard

Additional currency formats

Open lalalostyou opened this issue 3 years ago • 6 comments

Please confirm you have done the following before posting your bug report:

Describe the bug How can I change the currency format to the amount, non-breaking space, decimal is fractional separator, comma is thousand separator.

As of now the current default digit separator in snipe it is image

To Reproduce Steps to reproduce the behavior:

  1. Go to 'settings'
  2. Click on 'localization'
  3. Scroll down to 'currency'
  4. See error there are only two default value.

Expected behavior I would like to have another format option in Settings>Localization> Currency. (A decimal as fractional separator, and comma as thousand separator)

Screenshots Uploading image.png…

Server (please complete the following information):

  • Snipe-IT Version 5.1.1
  • OS: [e.g. Ubuntu, CentOS] Windows Server 2016
  • Web Server: [e.g. Apache, IIS] IIS
  • PHP Version 7.3.7

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6] none
  • OS: [e.g. iOS8.1] none
  • Browser [e.g. stock browser, safari]none
  • Version [e.g. 22]

Error Messages

  • WITH DEBUG TURNED ON, if you're getting an error in your browser, include that error
  • If a stacktrace is provided in the error, include that too.
  • Any errors that appear in your browser's error console.
  • Confirm whether the error is reproducible on the demo: https://snipeitapp.com/demo.
  • Include any additional information you can find in storage/logs and your webserver's logs.
  • Include the output from php -m (this should display what modules you have enabled.)

Additional context

  • Is this a fresh install or an upgrade? fresh install
  • What OS and web server you're running Snipe-IT on Windows Server 2016
  • What method you used to install Snipe-IT (install.sh, manual installation, docker, etc) MANUAL
  • Include what you've done so far in the installation, and if you got any error messages along the way. NO ERROR
  • Indicate whether or not you've manually edited any data directly in the database.

Add any other context about the problem here.

Please do not post an issue without answering the related questions above. If you have opened a different issue and already answered these questions, answer them again, once for every ticket. It will be next to impossible for us to help you.

lalalostyou avatar Feb 10 '21 01:02 lalalostyou

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Feb 10 '21 01:02 welcome[bot]

@lalalostyou I don't understand. The format of 1,500.34 is the default behavior. If you want the opposite, 1.500,34, you would change that in Admin Settings > Localization.

snipe avatar Mar 10 '21 22:03 snipe

@snipe Why there is no format that is used in Europe, i.e. no dot, decimal places separated by a comma? 1234,56

tylkofarci avatar Dec 18 '21 21:12 tylkofarci

@snipe Most European countries use space for thousands and comma for decimal (ex : 1 000 000,45) If the sequence includes a dot its not a valid number in our countries. This creates problems with exports and when copying and comparing prices with other systems https://en.wikipedia.org/wiki/Decimal_separator#Examples_of_use

niklasskoldmark avatar May 06 '22 10:05 niklasskoldmark

It would REALLY help to have official support for the format 12345,67 since right now, no export of reports works alright (in order to arrive in excel i.e.). If we choose 12.345,67 - export to excel gives exactly that and that will not work. Excel (Open-XML) gets it horribly wrong since it seems to interpret the first dot as decimal place giving 12.000,00 -> 12,00 and if it is missing (value below 1000) it ignores the decimal comma and takes all numbers as integers 333,33 -> 33333,00. Can I fix this in anyway waiting for official support of the format 12345,67?

SeniorSolutionArchitect avatar Sep 12 '22 10:09 SeniorSolutionArchitect

You can help by testing this PR, with your preferred format and other ones.

snipe avatar Sep 12 '22 10:09 snipe