Changing asset model causes data lost for custom text area
Please confirm you have done the following before posting your bug report:
- [No ] I have enabled debug mode
- [✔ ] I have read checked the Common Issues page
Describe the bug Custom Field that is a text area does not preserve values upon changing asset model that shares similar custom fields.
To Reproduce Steps to reproduce the behavior:
- Go to 'edit asset'
- Change model to another with the custom field
- Custom text area is now blank
Expected behavior Changing asset models with similar custom text area should retain the data.
Server (please complete the following information):
- Snipe-IT Version: 4.9.0 [Reproduced in Demo 4.9.0, 4.9.1]
- OS: [Windows Server 2016]
- Web Server: [IIS]
- PHP Version: 7.2.2
Desktop (please complete the following information):
- OS: [Win10 1809]
- Browser [Chrome]
- Version [Version 80.0.3987.163 (Official Build) (64-bit)]
Error Messages
- [✔] Confirm whether the error is reproducible on the demo: https://snipeitapp.com/demo.
Additional context
- Is this a fresh install or an upgrade? [Upgraded from Fresh Install of 4.8.0]
- What method you used to install Snipe-IT (install.sh, manual installation, docker, etc) [Github]
- Indicate whether or not you've manually edited any data directly in the database [No]
Add any other context about the problem here.
Please do not post an issue without answering the related questions above. If you have opened a different issue and already answered these questions, answer them again, once for every ticket. It will be next to impossible for us to help you.
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
Yes this issue is still relevant.
On Tue, Jun 9, 2020, 1:17 PM stale[bot] [email protected] wrote:
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/7957#issuecomment-641546340, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBIGEQUE2EFDYG24TOZUL3RV2KGVANCNFSM4MFVELDQ .
Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
Yes this issue is still relevant.
Regards, Justin
On Sat, Aug 8, 2020 at 2:24 PM stale[bot] [email protected] wrote:
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/7957#issuecomment-670975269, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBIGEQI2RKDJU6QQFRAJM3R7W675ANCNFSM4MFVELDQ .
Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
Yes
On Sun, Oct 11, 2020, 5:27 PM stale[bot] [email protected] wrote:
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/7957#issuecomment-706794451, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBIGEVO6FBGKA7JX5PX7M3SKJEPZANCNFSM4MFVELDQ .
Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
Yes
On Fri, Dec 25, 2020, 7:23 AM stale[bot] [email protected] wrote:
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail. This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/snipe/snipe-it/issues/7957#issuecomment-751262637, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBIGEQHRG5NUACQEMAJF33SWSU53ANCNFSM4MFVELDQ .
Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!
I feel like this hasn't come up much since it's uncommon for folks to change the model of an existing asset. It either is or it isn't a particular model, but I can see the edge case if you've, for example, broken out your models into more specific versions.
This seems to be fixed:
https://github.com/user-attachments/assets/900d5bf0-63d9-4c1a-9ea8-c6c9846c0a41