snipe-it icon indicating copy to clipboard operation
snipe-it copied to clipboard

Add a file tab on a Company

Open ralphmodales opened this issue 1 year ago • 3 comments

Description

Adding a file tab on a Company based on the file uploads of asset and users, and company. This is to check for the falls of the assets and a user of a company.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Check the Company tab and there's a file option for it.

  • [x] Test A
  • [x] Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

  • [x] I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
  • [x] I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

ralphmodales avatar Jul 02 '24 03:07 ralphmodales

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Jul 02 '24 03:07 welcome[bot]

PR Summary

  • Introduction of 'Company.php' File In order to manage and process details related to companies, a new file called Company.php has been introduced. This file will aid in the handling of company-related operations and serve as a centralized location for code that deals with company information.

what-the-diff[bot] avatar Jul 02 '24 03:07 what-the-diff[bot]

I'm not really sure what's happening in this - we already have a Company model and view, so not sure why they'd be added here. (Also please make sure you submit PRs against develop, not master.)

snipe avatar Jul 03 '24 21:07 snipe