snipe-it icon indicating copy to clipboard operation
snipe-it copied to clipboard

Add LDAP-Sync for Companies

Open aj-bi opened this issue 2 years ago • 6 comments

Description

Adds the LDAP sync for the companies. Code is copied from Locations. For people, the company can now also be synchronized.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Did a LDAP-Sync against a Active-Direcotry

Test Configuration:

  • PHP version: v7.4.28
  • MySQL version: 10.5.15
  • Webserver version: 2.4.53
  • OS version: Linux Debian

Checklist:

  • [x ] I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
  • [x ] I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
  • [x ] My code follows the style guidelines of this project
  • [ x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

aj-bi avatar Nov 25 '22 08:11 aj-bi

  • Added LDAP OU field to the Company Model
  • Updated CompaniesController with new fields and validation rules for ldap_ou
  • Updated API/CompaniesController with new fields in $fillable array, added setLdapOuAttribute function

what-the-diff[bot] avatar Nov 25 '22 08:11 what-the-diff[bot]

https://github.com/snipe/snipe-it/issues/10698

aj-bi avatar Nov 25 '22 09:11 aj-bi

@uberbrady can you put a review on this? It's been open a while and I think you are the most intimately familiar (recently) with LDAP

snipe avatar Feb 13 '23 19:02 snipe

Can anybody tell me the status? or the planning on the road map?

Peenpower avatar Nov 14 '23 15:11 Peenpower

+1 I'm very interested in this feature, as this would automate the process of setting the company for every new user, with multicompany enabled.

SebastianKlimczok avatar Feb 02 '24 10:02 SebastianKlimczok

@Peenpower , @SebastianKlimczok Feel free to patch your installation yourself. The "code" is almost the same as in "Locations", simply adapted to "Companies". Unfortunately I have no influence... whether it gets into the official repo or not.

aj-bi avatar Feb 02 '24 16:02 aj-bi

+1

gertz22 avatar Apr 02 '24 08:04 gertz22

Hi there - we have a more recent version of this in #10698 and there are a lot of merge conflicts, so I'm going to close this one for now.

snipe avatar Aug 10 '24 17:08 snipe