snipe-it icon indicating copy to clipboard operation
snipe-it copied to clipboard

Added #11686: add asset serial to license seat

Open cuuush opened this issue 3 years ago • 1 comments

Description

adds a column for asset serial in the license seats view. This allows organizations who use licenses for hardware support contracts (Cisco SmartNet, Juniper JCare) to easily create reports (via table export button) of support contracts and their associated hardware serial numbers.

Fixes #11686

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

ran phpunit, no relevant tests failed. ran browser tests (Laravel Dusk), no relevant tests failed.

Test Configuration:

  • PHP version: 7.4.26
  • MySQL version: mariadb:10.6.4-focal
  • Webserver version: PHP built-in server 7.4.26
  • OS version, docker

Checklist:

  • [x] I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
  • [x] I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes

cuuush avatar Sep 01 '22 20:09 cuuush

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

welcome[bot] avatar Sep 01 '22 20:09 welcome[bot]