snipe-it icon indicating copy to clipboard operation
snipe-it copied to clipboard

Minor improvement - Sidebar Button overflows into other elements

Open yannikp opened this issue 3 years ago • 4 comments

Debug mode

Describe the bug

The border of the sidebar-button overflows into other elements and thus shifts them slightly.

I have this custom CSS in place to fix it. .sidebar-toggle.btn { border-radius: 3px; box-shadow: none; border-top: 0px solid transparent; border-bottom: 0px solid transparent; padding-left: 15px; padding-right: 15px; padding-top: 12px; padding-bottom: 12px; margin-left: -47px; margin-top: 2px; }

Reproduction steps

Open the Snipe-IT Demo on a Desktop with a resolution of at least 1100px in width and click on "Create New" "Admin".

Expected behavior

A pristine interface :D

Screenshots

grafik

Snipe-IT Version

Snipe-IT Demo

Operating System

Snipe-IT Demo

Web Server

Snipe-IT Demo

PHP Version

Snipe-IT Demo

Operating System

Windows, macOS

Browser

Chrome, Firefox

Version

Chrome v104, Firefox v105

Device

Desktop

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

yannikp avatar Aug 29 '22 11:08 yannikp

Can confirm that I had this issue on my instance and that the CSS you shared fixed it. I have no clue how you noticed this haha

ccj9874 avatar Aug 30 '22 12:08 ccj9874

We'd be happy to take a PR for this :)

snipe avatar Aug 30 '22 20:08 snipe

Understandable ^^ Is it this file where I would need to add the change? /resources/assets/less/overrides.less

yannikp avatar Aug 31 '22 06:08 yannikp

Yep - you don't need to submit compiled assets though, we do that on our end :)

snipe avatar Aug 31 '22 16:08 snipe