snipe-it
snipe-it copied to clipboard
snipe
Add stock / quantity replenish (refill) function for consumables
Description
This branch extends the functionality to add stock number of consumables by having replenishment process instead of updating it from edit button. additionally new table is created to store the historical trace of each replenishments
Fixes # (issue)
Type of change
- [x] New feature (non-breaking change which adds functionality)
How Has This Been Tested?
- [ ] Test A :
- [ ] Test B :
Test Configuration:
- PHP version: 7.4.27
- MySQL version : 10.4.22
- Webserver version: Apache 2.4.52
- OS version: Windows 10
Checklist:
- [x] I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
- [x] I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
screens
consumable table - new button for replenishment
replenish page
consumable view
- this view is still on progress.. adding tabs to switch between consumable users & replenish history
- still finding out how to get the data from table and put it in the table 🤔
updated from last commit
consumables view is working now
checkout history
replenish history
user view has 2 informations now
recent activity for replenish added
Next:
- Add field for order number : done
- Add field for document / image upload (?)
updated from last commit
implements order number
during replenish
view
##user
This would make snipeit's consumables actually work as we'd expect... Just waiting on this merge.
@snipe This has been a requested feature for a couple years now, and seems to have been stuck waiting for review for a year now. Any update?
The same mechanic could be used in the Accessories too.
They really should be simple such as an item with a counter that can go up with orders and down with checkouts.
The same mechanic could be used in the Accessories too.
They really should be simple such as an item with a counter that can go up with orders and down with checkouts.
I disagree that this should be used for accessories, as if more accessories are purchased then the total quantity should increase and checked out accessories can be checked back in, whereas with consumables the checked out items are well "consumed" and therefore cannot be checked back in but should be replenished when more consumables are ordered without the total quantity increasing, like this new feature would add.
The same mechanic could be used in the Accessories too. They really should be simple such as an item with a counter that can go up with orders and down with checkouts.
I disagree that this should be used for accessories, as if more accessories are purchased then the total quantity should increase and checked out accessories can be checked back in, whereas with consumables the checked out items are well "consumed" and therefore cannot be checked back in but should be replenished when more consumables are ordered without the total quantity increasing, like this new feature would add.
However currently adding new accessories, you're required to add your quantity to the current quantity which is really open to human error. It also asks for an order number but only allows a single accessory ID to a single order, where as it's really a Many (Orders/Checkin) to One (Accessory/Consumable) to Many (Checkouts) relationship. However the difference between consumables is that you simply never checkin once its checked out.
