Stéphane Nicolet

Results 32 comments of Stéphane Nicolet

I suggest to rename the variable `REPO_DIR` to `CLONE_DIR` to avoid the semantic clash between `REPO` and `REPO_DIR`. Maybe also the default name for `CLONE_DIR` could be `cloned`

It would also be nice to have a two lines description of the script near the top of the file, with maybe two examples: 1. `make_release.py --help` 2. a complete...

This is how we do it in `appveyor.yml`: https://github.com/official-stockfish/Stockfish/blob/62a0b65ff886f8f4895d854705c0c870e6a2a834/appveyor.yml#L52

This has the risk to make unbounded search extensions if the transposition table contains the pv line? We have the same guard in step 15.

Also note that you are simplifying an Elo gaining patch which has been committed a few hours ago: 1. Are we sure the "simpler" version would have been an Elo...

I am convinced that this is important stuff concerning the readability and the ease of reasoning about Static Exchange Evaluation of moves, when we write or tweak our see()-related pruning...

I have tested speed locally with both clang and gcc, and found no speed penalty. 1) two runs of bench at depth 22 in parallel (clang 11): ``` testedpatch Total...

> Interpolating RGB colors is a bad idea in itself, but this doesn't even account for gamma. See https://www.alanzucconi.com/2016/01/06/colour-interpolation/ This comment is over-aggressive, if you ask me. 1. I knew...

Do you guys think that the algorithm introduced in https://github.com/official-stockfish/Stockfish/commit/73018a03375b4b72ee482eb5a4a2152d7e4f0aac would help with the positions discussed in this PR ?

So this is an implementation of my algorithm to detect and avoid search explosions, rebased on current master: https://github.com/snicolet/Stockfish/commit/b1ae6262ae42546fcd7603ca004ef0707df225be The main difference — compared to the buggy, partial algo in...