Thruk icon indicating copy to clipboard operation
Thruk copied to clipboard

Restrict `Reschedule next check` for passive checks

Open llange opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. Since we have so few passive check, some of our users accidentally use the Reschedule next check on those passive checks - either in Quick Status or in the service detail page. This is not encouraged, because those checks have no useful check_command, and this has the unintended consequence of changing the check output (and return code), with possible notification firing, havoc in the history, etc... We try to fight this behaviour with:

  • Education of the users
  • Use of check_dummy as a check_command reminder (but this will also impact output, return code, notification, history, etc...)
  • Removal of that command from Quick Status (with cmd_quick_status) but that's not fun for the 99,99% active checks
  • Disabling the schedule* commands with command_disabled for this specific Group of users (but still not fun with the active checks needing it)

Unfortunately, with user turnover, and the low number of passive checks, we still have (too many) clicks on that function.

Describe the solution you'd like We could benefit from what I believe is a non-existing feature : conditionally restricting commands for (specifically) passive checks. I.e., like using command_reschedule_alias but with a disable action instead of a master_service_description. Or, an extension of command_disabled to only deal with passive checks.

Bonus point if the UI is in synch, i.e. not showing the "Reschedule next check" for passive checks (or show it disabled), idem for the service detail page.

Describe alternatives you've considered As described previously:

  • Use of check_dummy as a check_command reminder (but this will also impact output, return code, notification, history, etc...)
  • Removal of that command from Quick Status (with cmd_quick_status) but that's not fun for the 99,99% active checks
  • Disabling the schedule* commands with command_disabled for this specific Group of users (but still not fun with the active checks needing it)

Additional context n/a

llange avatar Jan 06 '22 08:01 llange

Hello @sni , just wanted to have your thoughts about this feature request... thanks in advance !

llange avatar Mar 17 '22 17:03 llange

hi, sorry for coming late to this discussion. I don't think there is an easy solution for this. But one might be a check_dummy, which simply returns the current state/output by using macros. Then you can run this active check as often as you like and it won't change a thing.

sni avatar Jan 09 '23 09:01 sni