xcms icon indicating copy to clipboard operation
xcms copied to clipboard

group—mzclust

Open yuan596 opened this issue 3 years ago • 5 comments

Hi,I want to group the peaks by using the mzClust algorithm.But I found some differences between the algorithm introduced in reference and codes.And I want to ask some question:

  1. Where is the “R_mzClust_hclust” ?
  2. What is the “last cluster in C” ? 3.In the mz_clust codes, why is it “if(binclust != 1)” instead of “ if(binclust == 0)” ?[ 4500E484-5D36-4D27-8FC5-D1B705ADE25B D2FAD649-D8D0-4CEC-9104-E0FBC61D485F E74F8802-D9DA-4C76-8B3E-47806650C8AE

](url)

yuan596 avatar Nov 03 '20 12:11 yuan596

Hi, thanks for looking into this ! To find the code, you can use the great github search: https://github.com/sneumann/xcms/search?q=R_mzClust_hclust to find it. If there are discrepancies, you could consider writing a unit test function to create mockup data and check the expected output. Yours, Steffen

sneumann avatar Nov 03 '20 12:11 sneumann

Hi,thank you for your reply. I will try to write a function to test the codes. But how can l use 'mzClust_hclust.c' in 'mzClust.R' ?

yuan596 avatar Nov 03 '20 13:11 yuan596

The R function .C() is calling into a function written in the C language: .C("R_mzClust_hclust", ...) For the concepts please check out e.g. https://pj.freefaculty.org/guides/Rcourse/ffi-1/ffi-1.pdf or the R manual https://cran.r-project.org/doc/manuals/r-release/R-exts.html#System-and-foreign-language-interfaces Yours, Steffen

sneumann avatar Nov 03 '20 15:11 sneumann

Thank you!

yuan596 avatar Nov 04 '20 00:11 yuan596

Hi,when I used mzClust.R ,error occurred: 58F617AE-3083-446A-A32A-F1574D2F52D3

yuan596 avatar Sep 07 '22 03:09 yuan596