xcms icon indicating copy to clipboard operation
xcms copied to clipboard

Published 20 hours ago • verified publisher icon sneumann

mzo added from centWave & some polarity issues

Open hpbenton opened this issue 9 years ago • 4 comments

Added polarity splits for MPI function as well - before was only in non parallel version Added export of mzo & mzoscan from centWave

hpbenton avatar May 05 '15 22:05 hpbenton

Hi,

I fixed the typo in MPI.R, please pull from https://github.com/sneumann/xcms/tree/hpbenton-master Please check that it now does what you intended.

Can you also please add documentation to avoid that WARNING, and this time run R CMD check afterwards ?

* checking for missing documentation entries ... WARNING
Undocumented code objects:
  ‘ppm’ ‘ppmDev’

Yours, Steffen

sneumann avatar May 10 '15 19:05 sneumann

Hi Paul, thanks for the pull request. I'll need a moment to digest the 250 commits, and also work with @jotsetung to get the github and SVN in sync. Yours, Steffen

sneumann avatar Aug 10 '16 20:08 sneumann

I was messing around with code and different branches just now. Steffen go ahead and ignore the pull and I'll send a diff later that maybe more helpful and easier. I also want to look at the xcms3 changes, exciting stuff.

hpbenton avatar Aug 10 '16 22:08 hpbenton

amazing! that's a lot of commits! There might indeed be some difficulties merging that, since the devel branch has now become the sort of master that is in sync with Bioconductor.

jorainer avatar Aug 11 '16 05:08 jorainer