Víctor Fernández de Alba

Results 458 comments of Víctor Fernández de Alba

@pnicolli @danalvrz @ksuess merging this one as well!! Please check if there's something wrong even after merging.

@ksuess where do you need `@parcel/watcher-darwin-x64` ? No package in core needs it as a direct dep. I never use the watcher... I only relied on the built things. Core...

@sabrina-bongiovanni didn't we have already a className that identifies the root in the body class?

@stevepiercy how do we do this? However, we always have the specific Storybook URL preview, right? Wasn't it necessary to enable something for rtd to do it if it detects...

@stevepiercy no, the redirect we can live with the fact that it won't point to the PR build. I guess that would mean too much hassle. I was refering to...

I made you maintainer of the projects in RTD. I checked the "build PRs" config, let's see if that makes the trick.

@tazsq I think we cannot change this now.

@tazsq Closing for now, thanks for caring anyways!

@JeffersonBledsoe @ichim-david if we do this, we need that also in `@plone/components` (for now) to have it also in the future theming.

@JeffersonBledsoe it seems you pushed more changes than the needed in this PR. Can you take a look, please? you deleted things and files, that we cannot remove.