patreon-downloader icon indicating copy to clipboard operation
patreon-downloader copied to clipboard

Duplicate attachment files in zip file

Open fireattack opened this issue 1 year ago • 4 comments

When downloading a post with file attachment e.g.

image

The downloaded zip file will have two copies of this file:

image

This only starts to happen lately.

fireattack avatar Sep 14 '24 13:09 fireattack

Just to add to this, it seems there are two links appearing within the Patreon post; I assume this is why the downloader is downloading them twice.

File Name: FileName1.txt
URL: https://www.patreon.com/file?h=123456789&i=1111111
File Name: FileName1.txt
URL: https://c10.patreonusercontent.com/4/patreon-media…sh=XXXXXX

taylorn-ai avatar Sep 20 '24 20:09 taylorn-ai

That makes sense as to why there are to. What would the expected outcome be from your perspectives?

sneat avatar Oct 18 '24 00:10 sneat

Can we de-duplicate them before downloading? I think the first link would eventually redirect to the second; and even if not, it should be possible to tell by content-length and/or attachment filename.

fireattack avatar Oct 18 '24 03:10 fireattack

That makes sense as to why there are to. What would the expected outcome be from your perspectives?

Expected outcome would be for there to be no duplicate files...

I don't know if they can be de-duplicated before downloading as you'd have to read the file/stream to get the content length, and by that point it's already downloaded. I've just noticed that this is no longer happening for me anyway, so perhaps Patreon changed something?

Also, as a suggestion, rather than having a button for "Download xx files", maybe a checklist so that if this were to happen again, we can select which files we want to download.

taylorn-ai avatar Oct 18 '24 20:10 taylorn-ai