bridgy icon indicating copy to clipboard operation
bridgy copied to clipboard

Received several webmentions that didn't include the `target` URL as a mentioned URL in the `source`

Open davidcelis opened this issue 2 years ago • 5 comments

Hiya! I had a nice number of webmentions (about 121) come through over the last day after setting up bridgy. I was able to process most of them without a hitch, but seven of them came in a weird state, with bridgy's generated source page not actually including the target link:

  • https://brid.gy/comment/mastodon/@[email protected]/109915187368424578/109916806924004629
    • Target: https://davidcel.is/notes/1628618334444455032
  • https://brid.gy/comment/mastodon/@[email protected]/109820982991007881/109824002263622277
    • Target: https://davidcel.is/notes/1622753335784244463
  • https://brid.gy/comment/mastodon/@[email protected]/109827688778694359/109829232610570651
    • Target: https://davidcel.is/notes/1622753335784244463
  • https://brid.gy/comment/mastodon/@[email protected]/109820982991007881/109827688778694359
    • Target: https://davidcel.is/notes/1622753335784244463
  • https://brid.gy/comment/mastodon/@[email protected]/109827688778694359/109829210625034179
    • Target: https://davidcel.is/notes/1622753335784244463
  • https://brid.gy/comment/mastodon/@[email protected]/109778842648443627/109778857029328242
    • Target: https://davidcel.is/notes/1619907407377335527
  • https://brid.gy/comment/mastodon/@[email protected]/109778842648443627/109780396186439489
    • Target: https://davidcel.is/notes/1619907407377335527

Bridgy clearly found the correct post for each of those interactions, but for some reason didn't include the target URL in its source page, so I'm not really sure what's going on there

davidcelis avatar Feb 26 '23 17:02 davidcelis

Interesting! Thanks for reporting. Looks like these were sent to your replies in those threads as well as to your original post. That's why they're missing the original post's target URL, like you mention. I think the separate webmentions to the original post did go through though. For example, here are the corresponding webmentions for the last two you mention, these source pages do contain the davidcel.is target URL:

  • https://brid.gy/comment/mastodon/@[email protected]/109776142147798890/109778842648443627
  • https://brid.gy/comment/mastodon/@[email protected]/109776142147798890/109776826643749474

So, sounds like you hopefully got valid wms for every reply, and these were invalid extras. I'll keep this open to track fixing and not sending those!

snarfed avatar Feb 26 '23 22:02 snarfed

Ohh snap! Yup, you seem to be right; I do think I got all of the proper mentions and now I'm remembering that I thought I saw something duplicated on my end before tracking these few failures. Thank you for helping me look into it and for the future fix!

davidcelis avatar Feb 26 '23 23:02 davidcelis

@snarfed Hey again! I just noticed some failed webmentions on my end that follow the same pattern, where the target URL wasn't included in the source HTML. One example:

https://brid.gy/comment/mastodon/@[email protected]/112073199019621267/112074944454786511

In this case, I don't have any other webmentions I've received on my end that were a duplicate but which were valid. This was the only one I received for the given interaction, but I ended up processing it as invalid because of the URL not being included in the source. I think I may have noticed something similar with another post of mine after a thread of replies got deep enough, so I'm wondering if there's an issue that crops up once nested replies reach a certain depth. In this case, one person and I had a back-and-forth and, after a depth of four replies to my original post, I stopped getting successful webmentions for anything else in that thread.

davidcelis avatar Mar 11 '24 06:03 davidcelis

Hmm! Interesting. Sorry for the trouble! We don't have an explicit depth limit; we use https://docs.joinmastodon.org/methods/statuses/#context (authenticated) to get Mastodon replies, and this is far below its threshold, so I'm not sure what's going on yet.

snarfed avatar Mar 11 '24 15:03 snarfed

No worries! There probably isn't harm in me just skipping the target URL verification step for webmentions coming from brid.gy for now, but I'll be curious to see if you're able to figure out why the original post's URL is missing. Thanks for taking a look!

davidcelis avatar Mar 11 '24 17:03 davidcelis