o/devicestate: allow remodeling back to an old snap revision that includes components
This will enable us to remodel back to a snap revision that was already installed in the past (somewhere in the sequence), assuming that the snap has all of the components that are needed already installed as well.
Based on https://github.com/canonical/snapd/pull/15046.
Wed Mar 19 22:11:17 UTC 2025 The following results are from: https://github.com/canonical/snapd/actions/runs/13929999369
Failures:
Preparing:
- google-nested:ubuntu-24.04-64:tests/nested/manual/hybrid-fde-dbx
Executing:
- google-nested:ubuntu-24.04-64:tests/nested/manual/split-refresh
- google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:passphrase_auth
- google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:install_optional_snap
- google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller
- google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:install_optional_snap_and_comp
- google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:install_optional_all
- google-nested:ubuntu-24.04-64:tests/nested/manual/muinstaller-core:plain
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:ignore
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close_mid_restart
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:close
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-pre-download:restart
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:regular
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-backoff
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:parallel
- openstack:opensuse-tumbleweed-64:tests/main/snap-refresh-hold
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-gating-from-snap
- openstack:opensuse-tumbleweed-64:tests/main/auto-refresh-retry
- openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
- google:ubuntu-25.04-64:tests/main/snap-ns-forward-compat
- google:ubuntu-25.04-64:tests/main/microk8s-smoke:edge
Restoring:
- openstack:debian-sid-64:tests/main/interfaces-timeserver-control
- openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
As discussed with @andrewphelpsj, it's unlikely this content will make 2.68.2. Keeping tag for the moment, will reevaluate when everything else is ready.
Codecov Report
Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.
Project coverage is 78.15%. Comparing base (
d6d95f0) to head (9d635cb). Report is 31 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| snap/snaptest/snaptest.go | 0.00% | 8 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #15060 +/- ##
==========================================
+ Coverage 78.09% 78.15% +0.06%
==========================================
Files 1190 1182 -8
Lines 158458 158715 +257
==========================================
+ Hits 123746 124043 +297
+ Misses 27017 26966 -51
- Partials 7695 7706 +11
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.15% <80.48%> (+0.06%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This PR is not going to make 2.68.2, moving to 2.69. @andrewphelpsj @pedronis
muinstaller tests are failing due to issues with kernel in 24/edge.