snapd icon indicating copy to clipboard operation
snapd copied to clipboard

snapcraft.yaml: fix missing primed packages in manifest

Open valentindavid opened this issue 11 months ago • 5 comments

valentindavid avatar Feb 05 '25 13:02 valentindavid

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@365a0c0). Learn more about missing BASE report. Report is 287 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #15029   +/-   ##
=========================================
  Coverage          ?   78.27%           
=========================================
  Files             ?     1156           
  Lines             ?   154329           
  Branches          ?        0           
=========================================
  Hits              ?   120806           
  Misses            ?    26095           
  Partials          ?     7428           
Flag Coverage Δ
unittests 78.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 05 '25 13:02 codecov[bot]

The attributes are there, but the manifest is still not correct. I will have to debug a bit deeper into this.

valentindavid avatar Feb 05 '25 13:02 valentindavid

Depends also on https://bugs.launchpad.net/snapcraft/+bug/2097440

valentindavid avatar Feb 05 '25 14:02 valentindavid

Mon Feb 17 12:18:08 UTC 2025 The following results are from: https://github.com/canonical/snapd/actions/runs/13179140672

Failures:

Preparing:

  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64
  • openstack:opensuse-15.6-64

Executing:

  • openstack:debian-sid-64:tests/unit/go:gcc
  • openstack:debian-sid-64:tests/unit/go:clang
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:kmsg
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-self-manage
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-serial-port
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-required-or-optional
  • google:ubuntu-25.04-64:tests/main/cgroup-devices-v2
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-helper
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups:uinput

Restoring:

  • openstack:debian-12-64:tests/unit/c-unit-tests-clang
  • openstack:debian-12-64:tests/unit/
  • openstack:debian-12-64:tests/unit/
  • openstack:debian-12-64:tests/unit/
  • google:ubuntu-25.04-64:tests/main/security-device-cgroups-strict-enforced

github-actions[bot] avatar Feb 05 '25 14:02 github-actions[bot]

I have done a work-around for https://bugs.launchpad.net/snapcraft/+bug/2097440

valentindavid avatar Feb 05 '25 16:02 valentindavid

Adding this to 2.68.1, there is a customer waiting for this.

ernestl avatar Feb 17 '25 10:02 ernestl