client: fix typo in json tags
this PR just fixes a typo in the json tags, from:
`json:"links,omitempy"`
to:
`json:"links,omitempty"`
Wed Feb 26 19:38:09 UTC 2025 The following results are from: https://github.com/canonical/snapd/actions/runs/13538251820
Failures:
Executing:
- google:ubuntu-20.04-64:tests/unit/go:clang
@knbr13 thanks for the patch. Have you already signed the CLA? If not, would you mind following the link from an earlier comment and signing it?
@knbr13 thanks for the patch. Have you already signed the CLA? If not, would you mind following the link from an earlier comment and signing it?
hi @bboozzoo, yes, I have signed the CLA yesterday,
@knbr13 can you rebase the branch? there have been some changes to the cla-checker and AFAIU it should be correct now.
Hi @knbr13, thanks for this fix, hope you do not mind, I took the liberty of doing rebase just in the interest of time given we are cutting a new release soon.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.08%. Comparing base (
a272aac) to head (cb60db0). Report is 179 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #14895 +/- ##
==========================================
+ Coverage 78.07% 78.08% +0.01%
==========================================
Files 1182 1185 +3
Lines 157743 158111 +368
==========================================
+ Hits 123154 123467 +313
- Misses 26943 26974 +31
- Partials 7646 7670 +24
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.08% <ø> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Hi @knbr13, I discussed the CLA issue with the responsible team. The new CLA check action works with CLA submission after its date of release. Would you sign again the CLA https://ubuntu.com/legal/contributors?
Hi @ernestl,
Thanks for the rebase! I’ve signed the CLA again as requested.
Rebased again to have latest fix for ARM64 run (using github runner instead of self-hosted runner)
This fix is non-essential to 2.68.2, moving to 2.69