snapd icon indicating copy to clipboard operation
snapd copied to clipboard

boot/initrafms.go: use systemctl reboot instead of /sbin/reboot

Open valentindavid opened this issue 1 year ago • 3 comments

We are trying to get rid of /sbin in favor for /usr/sbin in core-initrd.

Also we should call directly systemctl which should always be in PATH.

valentindavid avatar Nov 29 '24 09:11 valentindavid

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (5e81c9d) to head (cfef428). Report is 76 commits behind head on master.

Additional details and impacted files
@@       Coverage Diff       @@
##   master   #14778   +/-   ##
===============================
===============================

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 29 '24 10:11 codecov[bot]

Unfortunately the spread tests do not test this correctly. Since the only tests that trigger this do not repack pc-kernel with a fixed snap-bootstrap.

valentindavid avatar Dec 05 '24 15:12 valentindavid

Wed Apr 9 16:55:52 UTC 2025 The following results are from: https://github.com/canonical/snapd/actions/runs/14329796985

Failures:

Executing:

  • openstack:opensuse-15.6-64:tests/main/security-device-cgroups-required-or-optional
  • openstack:opensuse-15.6-64:tests/main/progress

github-actions[bot] avatar Feb 10 '25 19:02 github-actions[bot]