snapd icon indicating copy to clipboard operation
snapd copied to clipboard

nvidia: add support module with known nvidia libraries and globs

Open zyga opened this issue 1 year ago • 6 comments

Test data contains a list of shared objects from numerous nvidia drivers, spanning Ubuntu 18.04 to 22.04, with data from driver 390, 470, 510, 515, 525, 530, 535, 545 and 550.

Go unit tests verify that each glob, matches at least one library stored in test data, and that each library is matched by at least one glob. The only exception is globs corresponding to libglvndr, which are not present in the driver libraries.

Jira: https://warthogs.atlassian.net/browse/SNAPDENG-26663

zyga avatar Aug 02 '24 12:08 zyga

Please use the files from https://github.com/canonical/snapd/pull/14295

bboozzoo avatar Aug 07 '24 13:08 bboozzoo

I need to merge the .libs list from #14295 and make it work in a way that handles both spread and go. @ernestl if you merge #14295 I will pick this up after the break.

zyga avatar Aug 15 '24 10:08 zyga

We now have a number of "stray" patterns that can be classified into three groups:

  • stuff from ancient drivers that are not supported anywhere anymore
  • stuff from cuda-derived libraries that is never installed into the right location (/usr/lib/x86_64-linux-gnu/) and doesn't really do anything in practice - probably added without testing
  • stuff specific to tegra (needs extrator, .libs file)

I think the best way forward is to add an exception list of unverified patterns and file a follow-up task to try to reduce this list. That task is now filed as https://warthogs.atlassian.net/browse/SNAPDENG-31358

zyga avatar Aug 23 '24 12:08 zyga

Based on feedback from @zyga, removing this from milestone 2.67.

ernestl avatar Oct 21 '24 13:10 ernestl

A quick review with @pedronis resulted in a suggestion to keep all patterns but mark them as exceptions to review later.

zyga avatar Jan 30 '25 12:01 zyga

The PR restores original changes from #14293 which was merged prematurely and then reverted in #14298

bboozzoo avatar Feb 05 '25 09:02 bboozzoo