snapd icon indicating copy to clipboard operation
snapd copied to clipboard

interfaces/desktop: Improve launch entry and systray integration with session

Open er-vin opened this issue 1 year ago • 3 comments

This allows applications to notify the session about job progression and implement the status notifier item protocol.

er-vin avatar Jun 26 '24 14:06 er-vin

Found an issue with the confinement of the process which was providing those services. Now that it is properly confined it shows that the security tags were missing. This explains the new revision of this patch.

er-vin avatar Aug 08 '24 17:08 er-vin

@er-vin do you need help merging this?

zyga avatar Sep 09 '24 08:09 zyga

@er-vin do you need help merging this?

I'm not allowed to merge myself, the button is just not accessible to me as I'm not authorized. So I guess I'll need help for all my patches yes. I keep rebasing them from time to time but it's the best I can do. :-)

er-vin avatar Sep 09 '24 12:09 er-vin

Not reviewed in time, moving milestone to 2.67

ernestl avatar Sep 27 '24 13:09 ernestl

Just rebased it to ease merging later on.

er-vin avatar Sep 30 '24 17:09 er-vin

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (ac897ee) to head (3edcd70). Report is 139 commits behind head on master.

Files with missing lines Patch % Lines
interfaces/builtin/desktop.go 44.44% 4 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14132      +/-   ##
==========================================
+ Coverage   78.85%   78.87%   +0.01%     
==========================================
  Files        1079     1082       +3     
  Lines      145615   145950     +335     
==========================================
+ Hits       114828   115116     +288     
- Misses      23601    23638      +37     
- Partials     7186     7196      +10     
Flag Coverage Δ
unittests 78.87% <44.44%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 30 '24 17:09 codecov[bot]