snapd icon indicating copy to clipboard operation
snapd copied to clipboard

notify: Dont send refresh complete notification if snap refresh observe is connected

Open sergio-costas opened this issue 9 months ago • 1 comments

The new Refresh Awareness specification moves all the work of showing refresh progress and notifications into a specific snap. To detect when that snap is available or not, snapd checks if there is a snap with the snap-refresh-observe interface connected. In that case, it presumes that it will manage all the notifications, and won't send any by itself.

Unfortunately, only the "Pending refresh" notification checks this case, while the "Refresh complete" notification doesn't. This results in duplicated notifications.

This patch fixes this.

Thanks for helping us make a better snapd! Have you signed the license agreement and read the contribution guide?

sergio-costas avatar May 03 '24 12:05 sergio-costas

@ZeyadYasser Moved the checking code into its own, shared function.

sergio-costas avatar May 07 '24 13:05 sergio-costas