snapd icon indicating copy to clipboard operation
snapd copied to clipboard

o/i/apparmorprompting/common: add prompting path patterns

Open olivercalder opened this issue 4 months ago • 3 comments

This PR splits out the path pattern matching, expansion, and precedence from the previous PR to add the common package in its entirety: #13668

The path pattern-related work there itself is largely a port of a previous PR against the prompting branch: https://github.com/olivercalder/snapd/pull/30

olivercalder avatar Mar 19 '24 03:03 olivercalder

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.93%. Comparing base (2b48274) to head (da0e748).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13730      +/-   ##
==========================================
+ Coverage   78.91%   78.93%   +0.02%     
==========================================
  Files        1043     1044       +1     
  Lines      134345   134537     +192     
==========================================
+ Hits       106014   106203     +189     
- Misses      21719    21720       +1     
- Partials     6612     6614       +2     
Flag Coverage Δ
unittests 78.93% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 19 '24 03:03 codecov-commenter

I've started to review this now

zyga avatar Mar 21 '24 10:03 zyga

This should be moved to the interfaces/prompting package, related to #13849 and #13850.

olivercalder avatar Apr 18 '24 06:04 olivercalder