snapd icon indicating copy to clipboard operation
snapd copied to clipboard

spread.yaml: switch to using ubuntu-image from latest/edge

Open alfonsosanchezbeato opened this issue 9 months ago • 5 comments

Now ubuntu-image is statically compiled so the issues with libc should be gone. Also, it has been detected that 2/stable creates partitions with unsupported features in older systems as it is shipping mkfs.ext4 in the snap, which comes from 20.04, but the one in latest is not shipping it.

alfonsosanchezbeato avatar Oct 20 '23 08:10 alfonsosanchezbeato

Codecov Report

Merging #13317 (5b96c45) into master (420a9a2) will decrease coverage by 0.02%. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master   #13317      +/-   ##
==========================================
- Coverage   78.82%   78.80%   -0.02%     
==========================================
  Files        1013     1013              
  Lines      126390   126390              
==========================================
- Hits        99624    99606      -18     
- Misses      20537    20552      +15     
- Partials     6229     6232       +3     
Flag Coverage Δ
unittests 78.80% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 20 '23 11:10 codecov-commenter

I see ubuntu-image failing to prepare in uc16

  • /snap/bin/ubuntu-image snap -w /home/image /home/image/pc.model --channel edge --snap /home/gopath/src/github.com/snapcore/snapd/tests/main/lxd/pc-kernel_1429.snap --snap /home/image/core_16-2.61+git4836.3d70bf83a_amd64.snap --output-dir /home/image [0] make_temporary_directories [1] determine_output_directory [2] prepare_image WARNING: proceeding to download snaps ignoring validations, this default will change in the future. For now use --validation=enforce for validations to be taken into account, pass instead --validation=ignore to preserve current behavior going forward WARNING: "core" installed from local snaps disconnected from a store cannot be refreshed subsequently! [3] load_gadget_yaml WARNING: volumes:pc:structure:2:filesystem_label used for defining partition roles; use role instead [4] set_artifact_names [5] populate_rootfs_contents [6] generate_disk_info [7] calculate_rootfs_size [8] populate_bootfs_contents [9] populate_prepare_partitions Error: Error running mkfs with content:

mkfs.ext4: invalid option -- 'd' Usage: mkfs.ext4 [-c|-l filename] [-b block-size] [-C cluster-size] [-i bytes-per-inode] [-I inode-size] [-J journal-options] [-G flex-group-size] [-N number-of-inodes] [-m reserved-blocks-percentage] [-o creator-os] [-g blocks-per-group] [-L volume-label] [-M last-mounted-directory] [-O feature[,...]] [-r fs-revision] [-E extended-option[,...]] [-t fs-type] [-T usage-type ] [-U UUID] [-jnqvDFKSV] device [blocks-count]

sergiocazzolato avatar Oct 20 '23 12:10 sergiocazzolato

Thanks for the reviews - I'm converting this to draft. I wonder if maybe we should move forward with using track 2 for UC16 and latest for the rest.

alfonsosanchezbeato avatar Oct 23 '23 07:10 alfonsosanchezbeato

Thanks for the reviews - I'm converting this to draft. I wonder if maybe we should move forward with using track 2 for UC16 and latest for the rest.

+1 on this approach.

ZeyadYasser avatar Oct 23 '23 07:10 ZeyadYasser

TODO: retry once https://github.com/canonical/ubuntu-image/pull/170 is merged

alfonsosanchezbeato avatar Jan 10 '24 14:01 alfonsosanchezbeato