snapd icon indicating copy to clipboard operation
snapd copied to clipboard

tests/nested: add check for update of base even on failed kernel

Open alfonsosanchezbeato opened this issue 1 year ago • 3 comments

Add test that checks that when a kernel and a base are installed at the same time and the kernel installation fails, the base is still installed.

alfonsosanchezbeato avatar Nov 14 '22 15:11 alfonsosanchezbeato

Opening this as a draft as this is actually failing at the moment. A decision on whether we should do something about this or not and how to behave in this case has not been taken yet.

alfonsosanchezbeato avatar Nov 14 '22 15:11 alfonsosanchezbeato

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d8b346a) 78.96% compared to head (e328d0e) 78.96%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12314      +/-   ##
==========================================
- Coverage   78.96%   78.96%   -0.01%     
==========================================
  Files        1028     1028              
  Lines      129811   129811              
==========================================
- Hits       102509   102507       -2     
- Misses      20914    20915       +1     
- Partials     6388     6389       +1     
Flag Coverage Δ
unittests 78.96% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 10 '24 15:01 codecov-commenter

This is still failing after the rebase, so the issue is still around even after the changes for single-boot updates.

alfonsosanchezbeato avatar Jan 12 '24 17:01 alfonsosanchezbeato