snapd icon indicating copy to clipboard operation
snapd copied to clipboard

interfaces/raw_usb: add write access required to support USB/IP

Open jocado opened this issue 4 years ago • 3 comments

This adds support for USB/IP to run using the raw_usb interface.

Related forum discussion here: https://forum.snapcraft.io/t/usb-ip-devices-access-binding-and-remote-attachement/25304

http://usbip.sourceforge.net/ https://www.kernel.org/doc/html/latest/usb/usbip_protocol.html

jocado avatar Sep 21 '21 18:09 jocado

Hmmm. Looks like the CLA check failed. We signed it as a company "entity", not individuals.

@mvo5 Do you know how we get that resolved ?

jocado avatar Sep 21 '21 18:09 jocado

Codecov Report

Merging #10821 (202ae1d) into master (ba87395) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10821   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files         890      890           
  Lines      100253   100253           
=======================================
+ Hits        78523    78528    +5     
+ Misses      16806    16803    -3     
+ Partials     4924     4922    -2     
Flag Coverage Δ
unittests 78.32% <ø> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
interfaces/builtin/raw_usb.go 100.00% <ø> (ø)
overlord/snapstate/snapstate.go 81.15% <0.00%> (+0.13%) :arrow_up:
overlord/hookstate/hookmgr.go 74.83% <0.00%> (+0.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ba87395...202ae1d. Read the comment docs.

codecov-commenter avatar Sep 21 '21 18:09 codecov-commenter

The CLA check issue should be resolved now.

anonymouse64 avatar Sep 24 '21 15:09 anonymouse64

@jocado is this still relevant? otherwise i'll close it soon

Meulengracht avatar Feb 21 '24 08:02 Meulengracht

@jocado is this still relevant? otherwise i'll close it soon

I was waiting for a comment from Alex regrading my points in https://github.com/snapcore/snapd/pull/10821#discussion_r746467637 , but it never got it, which is the reason this stalled.

While I think it would be good to support this functionality, I'm not working on any USB/IP use cases currently, so the time for me trying to contribute it has passed for now.

jocado avatar Feb 21 '24 09:02 jocado