pc-amd64-gadget icon indicating copy to clipboard operation
pc-amd64-gadget copied to clipboard

Published 20 hours ago • verified publisher icon snapcore

prepare-device: implement reference prepare-device hook

Open tonyespy opened this issue 1 year ago • 2 comments

Snapcraft.io points to this as the "reference" implementation of the amd64 gadget. However, no prepare-device hook makes this an incomplete reference, especially for private store operators

The proposed prepare-device hook would not change the behavior of the default PC gadget. However, it could then be forked and trivially modified to use for private store authentication.

This PR is just a backport of the reference hook added to the 22 and 24 branches.

tonyespy avatar Feb 14 '24 14:02 tonyespy

Tbh I'm a bit reluctant to backport this sort of changes, as this is just for reference and it is in the more modern gadgets. And new projects should be based on those, not on 20.

alfonsosanchezbeato avatar Mar 20 '24 17:03 alfonsosanchezbeato

also can we just make MODEL_APIKEY somehow snapctl set'able? such that verbantim pc gadget can just be used with serial vaults without need to maintain a forked gadged?

xnox avatar Mar 25 '24 09:03 xnox