core20 icon indicating copy to clipboard operation
core20 copied to clipboard

Convert hooks/024-configure-bootchart.chroot to static files

Open xnox opened this issue 4 years ago • 4 comments

We should convert hooks/024-configure-bootchart.chroot to simple static files in static/ folder.

There is nothing dynamic about what this hook does.

xnox avatar Sep 01 '21 19:09 xnox

The hook was needed because /lib/systemd/system/systemd-bootchart.service had to be modified from the original in the deb (that one is not static). Then I thought that it was better to create the rest of the files in the hook so all the implementation was in one place and future us would not miss parts of it. But I can change to static files if you are strongly against this.

alfonsosanchezbeato avatar Sep 02 '21 06:09 alfonsosanchezbeato

because /lib/systemd/system/systemd-bootchart.service had to be modified

I would have hoped that most things were possible to do with /usr/lib/systemd/system/systemd-bootchart.service.d/core.conf i.e. the only thing it can't do is remove depends/wants.

xnox avatar Sep 03 '21 11:09 xnox

because /lib/systemd/system/systemd-bootchart.service had to be modified

I would have hoped that most things were possible to do with /usr/lib/systemd/system/systemd-bootchart.service.d/core.conf i.e. the only thing it can't do is remove depends/wants.

I actually considered that, but it looked cleaner to me to avoid splitting the service config. No deb update is going to happen, so there would be no conflict anyway.

alfonsosanchezbeato avatar Sep 03 '21 16:09 alfonsosanchezbeato

Marking won't fix for the moment, but happy to disscuss further nonetheless.

alfonsosanchezbeato avatar Oct 15 '21 10:10 alfonsosanchezbeato