bootstrap-select icon indicating copy to clipboard operation
bootstrap-select copied to clipboard

1.14-Beta3 - items with " style="display: none;" still displayed on the list

Open DSCPEF opened this issue 2 years ago • 3 comments

Any list items tagged as hidden ( style="display: none;) still getting displayed , the issue does not exist under beta2.

Regards Igor

DSCPEF avatar Jul 08 '22 09:07 DSCPEF

Found an issue ... on the line 1808 , based on the original "if" all data selected for "mainData" was getting appended to the original list instead of rebuilding it from scratch. I removed "!" from matching condition so "this.selectpicker.main.data" gets reset every time when data from "mainData" should be added to it.

      if (!this.selectpicker.main.data) {
     .....
        }

changed to

      if (this.selectpicker.main.data) {
        ....
        }

Regards Igor

DSCPEF avatar Jul 13 '22 12:07 DSCPEF

@caseyjhol this line was added 4 months ago by you in https://github.com/snapappointments/bootstrap-select/commit/04cc1fd5abedc85c449d159d9fa6ea48e2e4a2f7, does what @DSCPEF suggest makes sense to you?

NicolasCARPi avatar Jul 13 '22 23:07 NicolasCARPi

Found an issue ... on the line 1808 , based on the original "if" all data selected for "mainData" was getting appended to the original list instead of rebuilding it from scratch. I removed "!" from matching condition so "this.selectpicker.main.data" gets reset every time when data from "mainData" should be added to it.

      if (!this.selectpicker.main.data) {
     .....
        }

changed to

      if (this.selectpicker.main.data) {
        ....
        }

Regards Igor

The case will happen in the bootstrap-select-1.14.0-beta3 , you can back version to 1.14.0-beta2. it will work as you expect.

parkour99 avatar Aug 24 '22 13:08 parkour99