bootstrap-select icon indicating copy to clipboard operation
bootstrap-select copied to clipboard

Deprecation warning when compiling with dart-sass (slash-div)

Open salami-art opened this issue 3 years ago • 3 comments

I had issues with node-sass, so I decided to updata to dart-sass, bootstrap-select works fine, however, i'm getting a deprecation warning for a line in the component's styles:

Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($amnt, 100) or calc($amnt / 100)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
26 │     $amnt: $amnt / 100; // convert to percentage if int
   │            ^^^^^^^^^^^
   ╵
    node_modules/bootstrap-select/sass/bootstrap-select.scss 26:12   fade()
    node_modules/bootstrap-select/sass/bootstrap-select.scss 352:43  @import
    [...]

It would be nice if someone updated the source code to use the newer recommended syntax. I am available for submitting a PR.

salami-art avatar May 30 '22 14:05 salami-art

Thanks for reporting this. Please submit a PR if you have the bandwidth and we'll get this merged - thanks!

caseyjhol avatar Jun 01 '22 20:06 caseyjhol

I don't know how to edit on the 1.13.X though, I'm still using that ( that piece of code was even changed on 1.14.X #2669 )

salami-art avatar Jun 06 '22 08:06 salami-art

Hi all, I've created a PR to resolve this issue. I've branched of v1.13.18 for this. Could this be released in a v1.13.19?

guustnieuwenhuis avatar Aug 24 '22 10:08 guustnieuwenhuis