dna-seq-gatk-variant-calling icon indicating copy to clipboard operation
dna-seq-gatk-variant-calling copied to clipboard

Not executed fastqc for specified inputs

Open nkimoto opened this issue 4 years ago • 1 comments

hi. I recently executed this pipeline for my job. But after I ran this pipeline and removed the output of the fastqc, I can't reproduce the output of fastqc (qc/fastqc/A-1.html for example).

After some experiment, I find this is because only first line is recognized as "inputs" by snakemake. So I fixed under the lines from https://github.com/snakemake-workflows/dna-seq-gatk-variant-calling/blob/6bde762e80eab54ba5d68681f64b58f66ab963b8/rules/qc.smk#L24-L27

to

    expand("qc/samtools-stats/{u.sample}-{u.unit}.txt", u=units.itertuples())
    expand("qc/fastqc/{u.sample}-{u.unit}.zip", u=units.itertuples())
    expand("qc/dedup/{u.sample}-{u.unit}.metrics.txt", u=units.itertuples())

I can get the expected results. Is this bug of expand module? Please explain what is happend.

nkimoto avatar Jun 21 '20 03:06 nkimoto

Not sure if it's a bug, I've asked in the issue I just opened.

For the time being, the easiest solution is to convert the input to a list:

 expand(["qc/samtools-stats/{u.sample}-{u.unit}.txt", 
         "qc/fastqc/{u.sample}-{u.unit}.zip", 
         "qc/dedup/{u.sample}-{u.unit}.metrics.txt"], 
        u=list(units.itertuples())

tdido avatar Feb 22 '21 17:02 tdido