Rolf Kristensen

Results 84 issues of Rolf Kristensen

No need to call `PopulateLocation` when `ShouldRecord` returns `false`. https://github.com/MindscapeHQ/raygun4net/blob/7acf911461b541a70d1d3b8d0d63d81021ccf272/Mindscape.Raygun4Net/Breadcrumbs/RaygunBreadcrumbs.cs#L36 https://github.com/MindscapeHQ/raygun4net/blob/7acf911461b541a70d1d3b8d0d63d81021ccf272/Mindscape.Raygun4Net/Breadcrumbs/RaygunBreadcrumbs.cs#L52

version
Patch Version
size/M

The pre-validation of whether active HttpContext is available provides very little value, but gives a performance hit.

breaking change
performance

It is silly that we have this code: ```c# public class DefaultHttpContextAccessor : IHttpContextAccessor { public HttpContextBase HttpContext { get { var httpContext = System.Web.HttpContext.Current; if (httpContext == null) return...

breaking change
ASP.NET 4
performance

Keep users from thinking that they need to call both: ```c# builder.AddNLog() builder.AddNLogWeb() ``` Avoid naming confusion with extension-methods from NLog.Extensions.Logging. Making it easier to explain users that they should...

breaking change
ASP.NET Core

Something similar to these: https://github.com/Xabaril/AspNetCore.Diagnostics.HealthChecks/tree/master/src Maybe something like this: - Setup static capture of NLog.InternalLogger-events on Warning and Error-Level. - Keeps tracks of alert count per NLog Target within the...

feature
up-for-grabs
ASP.NET Core

`EnableJsonLayout=true` fails with `NullReferenceException` when not having assigned `pipeline`-property. Fixing bug introduced with #125, that shows when using NLog 5.0 Resolves #163

bug

With help from NLog.Web.AspNetCore (when available).

Has been introduced with NET6, but it should be "easy" to implement equal solution in NLog.Internal. This will also help to convert nullable-value to non-nullable-value for #4036 From: ```c# if...

up-for-grabs
refactoring