Jacob R

Results 203 comments of Jacob R

@michalkleiner I didn't have time to try refactoring the use of the store, but I believe that I addressed everything else that you mentioned, including create #23422 to split out...

Closing in favour of #23456

We are having some discussion about how the newly defined custom dimensions on a tag should be applied. Here are the options that we discussed: 1. Apply to all tracking...

@9joshua The PR has been merged. So, the ability to define custom dimensions for a Matomo tag should be available as part of the next Matomo release.

Thank you for the input @michalkleiner . I have committed your suggested changes.

> @snake14 Did you check the resulting queries on a bigger database using different segment types and also on mysql and mariadb? We need to ensure that forcing an index...

> This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers These changes have been put into a [patch for Cloud](https://github.com/innocraft/matomo-cloud/pull/2499). It's been...

@sgiehl The change didn't appear to make a difference for a couple plugins, but it appeared to make an improvement for CustomVariables. Please [see this comment](https://innocraft.atlassian.net/browse/PG-3858?focusedCommentId=198703) on our internal ticket....

@sgiehl Just trying to check in again if we'd be able to merge this PR? Cloud testing went well. When profiling a customer's site with the index change enabled/disabled, two...

> @snake14 should we remove the config option to enable/disable that again? If it was well tested and it works as expected, I don't think the config option will be...