create-react-component-folder icon indicating copy to clipboard operation
create-react-component-folder copied to clipboard

"createIndex" flag throws error

Open Daveawb opened this issue 5 years ago • 5 comments

The createIndex flag does not function properly.

No components are created if the folder structures requested don't exist. If the folder structures do exist and empty index file is created but no components are created.

Daveawb avatar Sep 17 '20 08:09 Daveawb

Hi @Daveawb , I'm wondering how can I reproduce your problem? I'm a bit interested in this bug

PQTran avatar Dec 04 '20 11:12 PQTran

@Daveawb @PQTran thanks for taking interest in this. It is a little long since I created this. But if I remember correctly createIndex is only suppose to read components from the current folder and create an index file exporting those components. So not create components. Unless I am misunderstanding the main issue

snaerth avatar Dec 07 '20 08:12 snaerth

@snaerth and @PQTran I believe this was introduced when I wrote the template code. It's been a while since I looked at this issue, I'll try and reproduce again and provide steps.

Daveawb avatar Feb 05 '21 11:02 Daveawb

Awesome thanks @Daveawb

snaerth avatar Feb 05 '21 14:02 snaerth

So here's how I reproduced it.

image

However without --createindex

image

Note that Test does not exist at the time of creating the component.

I understand that the original intention was not to create any components but in this case specifically, we're creating a component AND creating an index of all components. This probably should either be fixed to allow component creation and a base index, or documented. Alternatively a separate command for indexing might be clearer that doesn't accept any arguments so that you can't mix the two up.

Daveawb avatar Feb 09 '21 11:02 Daveawb