Sindre Røkenes Myren

Results 196 comments of Sindre Røkenes Myren

Changing the `Now` function is defiantly the smallest change. I have no objections to it.

I see your point. Having it set to 20, I agree seam a bit arbitrary; it should probably rely on resources set for the specific resource. However, I think the...

I acknowledge the problem, but I think we need to come up with a better solution. I am thus going to close this issue now . Feel free to create...

Let's reopen/rename it then; just doing a bit of a cleanup in the issue tracker.

> I rely on Context and this validation uses just Context.TODO() which is critical for me. Ok I reopened #192 as well; I suppose we still need to track it....

Here is a suggestion (breaking change) for solving the circular dependencies: - In package Schema, replace the `Dependency query.Predicate` field with `Dependency *schema.Schema`. See JSON Schema for documentation/help. This is...

Actually query is also used within resource (my bad). But maybe a query interface could be defined for use in the resource package? There are a _few_ cases within the...

Maybe the least _invasive_ change would be to add a `GetDefaultLimit` to the existing `Resource` interface within the `query` package? Then alter the existing resource wrapper types in the `rest`...

I think that's solvable with clousure defaults, however I think we can probably just drop the optional interfaces all-together and make things easier. To make writing middleware easier we can...

> In your example you can not chain middleware right? Calling WithMiddleware more than once would override existing middleware. Also, I'm not a big fan of m interface{} argument. No,...