swb icon indicating copy to clipboard operation
swb copied to clipboard

SWB: undefined behavior if no "solve" directive present.

Open smwesten-usgs opened this issue 11 years ago • 1 comments

A user sent in a control file that contained neither a "SOLVE" nor a "SOLVE_NO_TS_FILE" directive, with the following result:

swb problem

It appears that if SWB has not actually run the simulation, undefined variable names creep into the routine responsible for naming output image files. Fix would be to test for at least one of the SOLVE statements or to test for valid variable values before attempting to formulate the name of the output file.

smwesten-usgs avatar Dec 04 '13 00:12 smwesten-usgs

Vic Kelson [email protected]

On Dec 3, 2013, at 7:08 PM, Steve Westenbroek [email protected] wrote:

A user sent in a control file that contained neither a "SOLVE" nor a "SOLVE_NO_TS_FILE" directive, with the following result:

It appears that if SWB has not actually run the simulation, undefined variable names creep into the routine responsible for naming output image files. Fix would be to test for at least one of the SOLVE statements or to test for valid variable values before attempting to formulate the name of the output file.

— Reply to this email directly or view it on GitHub.

ghost avatar Dec 04 '13 03:12 ghost