Malik Shahzad Muzaffar
Malik Shahzad Muzaffar
This change fixes [clang-analyzer warning](https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_14_2_X_2024-10-09-2300/el8_amd64_gcc12/build-logs/PhysicsTools/MVAComputer/log.html) with complete report at this [link](https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_14_2_X_2024-10-09-2300/el8_amd64_gcc12/llvm-analysis/report-d98050.html#EndPath) . It is true that we [only initialize](https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/MVAComputer/src/ProcMLP.cc#L106-L107) the `tmp` memory for first `iter`number of items. This Pr replaces...
This PR fixes clang-analyzer warnings - https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_14_2_X_2024-10-08-1100/el8_amd64_gcc12/build-logs/ - https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_14_2_X_2024-10-08-1100/el8_amd64_gcc12/llvm-analysis/index.html
UBSAN IBs show that we have runtime error [a] coming from `return (data_[layer][channel] >> bx) & 1;` at https://github.com/cms-sw/cmssw/blob/master/L1Trigger/CSCTriggerPrimitives/src/PulseArray.cc#L34 . [b] shows that it was generated from https://github.com/cms-sw/cmssw/blob/master/L1Trigger/CSCTriggerPrimitives/src/CSCAnodeLCTProcessor.cc#L688-L694 when `first_bx_layer`...
UBSAN IB shows that for workflow `29634.402` (step2 and step3) , there are runtime errors like [a]. It looks like this happens when `qbin` and `cp.qBin_` at https://github.com/cms-sw/cmssw/blob/master/RecoLocalTracker/SiPixelRecHits/src/PixelCPEFastParamsHost.cc#L231 are `0`....