Mohsin Zaidi

Results 45 comments of Mohsin Zaidi

@rvagg @RangerMauve, I've completed the integration with `focus`. All missing features, such as link traversal, progress tracking, link/node budgets, etc. are now included, and all `focus` and `patch` tests are...

@BigLep, here are the latest benchmarking results. The numbers are slightly higher than the [initial results](https://github.com/smrz2001/go-ipld-prime/pull/1#issuecomment-1152992683) due to (I believe) the integration with `focus`, `Progress`, etc. but still significantly lower...

> @smrz2001 : is there anything missing before a final review/merge? I don't think so, @BigLep, unless @rvagg or @RangerMauve would like to see something else - I'd be happy...

> Would it make sense to have a call with @smrz2001 and @rvagg (maybe @aschmahmann) and just devote some time to finalizing what we need to merge this so that...

Moving the "writable ADL" [discussion](https://github.com/smrz2001/go-ipld-prime/pull/4#issuecomment-1201716312) here: >> I also wanted to pass another thought by you, @RangerMauve. >> >> I can't get the idea out of my head that what...

> OK, I tried pulling this up into a `node/amend` package but have to concur with @smrz2001 that the interdependency is a bit too much. I started pulling some traversal...

> But then there's the question of whether accumulating all of this in memory is even what the user wants? With the current form, I could pass in a _huge_...

Thanks for the excellent suggestions, @rvagg! 🙏🏼 > * Instead of `plain*` in the language, maybe frame this as "basicnode" since that's become the common parlance for how we refer...

> * You're getting quite close to the `NodeBuilder` interface here, and as you've suggested already you're almost (or maybe are) building an ADL. So maybe its worth considering whether...

> ok, I grok `created` now, it was the naming that was throwing me and I see now how you're using it to modify behaviour Cool, I'll also rename the...