EQTransformer icon indicating copy to clipboard operation
EQTransformer copied to clipboard

Published 20 hours ago • verified publisher icon smousavi05

_decimalDegrees2DMS

Open dylanmikesell opened this issue 3 years ago • 1 comments

I would suggest renaming _decimalDegrees2DMS to _decimalDegrees2DM. You are not actually computing seconds, instead you have minutes with decimals. Therefore, the function name is misleading and when I was trying to figure out how to interpret the Y2000.phs event times this was ambiguous. There are many codes that do DMS or DM with the minutes having a decimal. I would stick to a name that more accurately describes what the function is actually doing.

This is defined on line 247 of associator.py.

dylanmikesell avatar Mar 15 '21 22:03 dylanmikesell

@dylanmikesell thanks, I'll apply the change.

smousavi05 avatar Mar 16 '21 18:03 smousavi05