fix: exhaust egress socket state on `poll`
At present, smoltcp only does a single pass of advancing the egress socket state. This means the layer above has to call poll in a loop to ensure sufficient progress has been made.
We already exhaustively progress the ingress state further up so doing the same thing for the egress state seems appropriate.
Codecov Report
:x: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 80.45%. Comparing base (17012eb) to head (671827b).
:warning: Report is 3 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/iface/interface/mod.rs | 66.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1059 +/- ##
=======================================
Coverage 80.45% 80.45%
=======================================
Files 81 81
Lines 24461 24461
=======================================
Hits 19681 19681
Misses 4780 4780
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@whitequark @Dirbaio I don't see any reason why not to do this.
I thought @Dirbaio had a case where this caused an issue?
I thought that as well and was digging in old issues and PRs, but I didn't find anything related to the egress. Most of the issues were with ingress resulting in a DoS.
@thomaseizinger Could you re-run/fix the test please? We'll merge it after.
@thomaseizinger Could you re-run/fix the test please? We'll merge it after.
I just accepted the new snapshot but I don't really know what it is testing.
Thanks!