async-process icon indicating copy to clipboard operation
async-process copied to clipboard

Add a backend for waitable handles

Open notgull opened this issue 1 year ago • 3 comments

This commit adds a new backend for the process reaper. Rather than waiting on a signal, it instead registers the process's pidfd into async-io and waits on that instead.

I've coded this backend to also allow for other systems to be registered here as well.

cc #49

notgull avatar Jan 15 '24 20:01 notgull

ok, the concept looks good overall, but I wasn't yet able to look through in detail.

fogti avatar Jan 17 '24 18:01 fogti

I realized that pidfd was only introduced in v5.4 of the Linux kernel, while Rust 1.63's current minimum version is v2.6. So we might still need to keep in the signal backend at least as a fallback.

notgull avatar Jan 25 '24 22:01 notgull

I realized that pidfd was only introduced in v5.4 of the Linux kernel, while Rust 1.63's current minimum version is v2.6. So we might still need to keep in the signal backend at least as a fallback.

This should be fixed as of now.

notgull avatar Feb 10 '24 05:02 notgull

@smol-rs/admins Any chance this PR can be reviewed?

notgull avatar Mar 23 '24 19:03 notgull