smol-ninja

Results 22 issues of smol-ninja

Solhint throws `GC: Invalid Solidity version gas-custom-errors` when `pragma solidity >=0.8.19

As discussed [here](https://github.com/sablier-labs/v2-open-ended/discussions/69), batch functions such as `cancelMultiple` and `withdrawMultiple` should be allowed to continue execution if one of the stream IDs revert. A sample implementation would look like the...

type: feature
priority: 2
work: complicated
effort: medium

Gas costs are relevant not only on Ethereum but on L2s as well. It can even influence the choice of the protocol by users. There is already an [ongoing discussion](https://github.com/sablier-labs/v2-core/discussions/767)...

effort: epic
work: complex
priority: 3
type: perf

A Codehawk auditor asked a really good question about the max value of `UD2x18`. Since its max value is capped by `type(uint64).max`, the exponent cannot represent a value bigger than...

type: docs
priority: 2
effort: low
work: clear

Similar to [v2-periphery](https://github.com/sablier-labs/v2-periphery/blob/staging/test/fork/Fork.t.sol): - Rename `ASSET` to `FORK_ASSET` - Rename `HOLDER` to `FORK_ASSET_HOLDER`

good first issue
type: test
effort: low
work: clear
priority: 3

Closes https://github.com/sablier-labs/v2-core/issues/861.

The contract names in the `MerkleLockup` integration tests do not include the name of the Merkle Lockup that they run tests for. Take the following example: https://github.com/sablier-labs/v2-periphery/blob/1bf91e6da480c1c9f03cb67d957b72db35b3108a/test/integration/merkle-lockup/ll/clawback/clawback.t.sol#L10-L10 is same as...

effort: low
priority: 3
type: test
work: clear

Same as https://github.com/sablier-labs/v2-core/pull/908

effort: high
type: test
priority: 2
work: complicated

good first issue
effort: low
type: test
priority: 2
work: clear

Closes https://github.com/sablier-labs/v2-periphery/issues/306