developer icon indicating copy to clipboard operation
developer copied to clipboard

Improving debugger.py

Open george-adams1 opened this issue 1 year ago • 4 comments

Sorry for the size of this PR. Issues to fix kept growing. See below:

Use typing to make the function signatures clearer. Use constants for hard-coded values. Create a helper function for checking file extensions. Improve the error handling in the walk_directory function. Use f-strings for better readability and performance. Add function and module-level docstrings for better understanding of the code.

george-adams1 avatar May 25 '23 23:05 george-adams1

thats great, thanks so much! the biggest issue with debugger is that context length becomes a problem much sooner than most. would like to fix that next, but happy to discuss what the right approach is in issues (i may move faster than issues here)

swyxio avatar May 29 '23 23:05 swyxio

i have not merged yet because i'm not sure that this is how i want the code style to be, but also have not closed because i might come around to it

swyxio avatar May 29 '23 23:05 swyxio

Ok sounds good. Let me know if there's anything else I can do.

george-adams1 avatar May 30 '23 03:05 george-adams1

you've done great. just share usecases/examples/pain points! i'll be refactoring quite a bit this week to accommodate the enlarged planning.

swyxio avatar May 30 '23 04:05 swyxio