Send move effectiveness data to the client

[Slayer95]

Also fixes disabledSource

[Slayer95]

Like this? Updated ~

[Slayer95]

Now literally using enums !

[Slayer95]

I took a step back and I think this is now looking much better

[Zarel]

This pull request introduces 1 alert when merging 54dde847a24cb4dfceeedebe7ec9a7cb116a9a55 into 1f8eeae108009779f2f119a42ac1cb52e8e0cc4c - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

---

Comment posted by LGTM.com

[Zarel]

This pull request introduces 1 alert when merging d003c103928cef54972f23632a077127ef7feb98 into 1f8eeae108009779f2f119a42ac1cb52e8e0cc4c - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

---

Comment posted by LGTM.com

[scheibo]

Is this blocked on Zarel and my opposition to MoveEffectiveness in its constants.ts file? I think making a MoveEffectiveness type literal (type MoveEffectiveness = 'invalid' | 'neutral' | 'immune' | 'resist' | 'weak') and putting it in Battle (where pokemon.ts can still import it - just with import {Battle, MoveEffectiveness} from './battle' would be preferable (or it could be in Pokemon and imported by Battle, though this seems sort of backwards)

[Slayer95]

More importantly, it's still missing client-side support. I'd have wanted this for AFD, but we are past the deadline !

[KrisXV]

This would be really nice to have implemented before BDSP comes out, are you still planning on working on it @Slayer95 ? If not I can take over.

[Slayer95]

Please go ahead @KrisXV

[AnnikaCodes]

@KrisXV are you working on this?

[mia-pi-git]

Going to close this since it's been inactive for several years. Please feel free to reopen it if it's still relevant.