smogon
Add Gastro Acid/Core Enforcer as a bad 'status' in the statusTable.
It always bothered me that Gastro Acid and Core Enforcer were not added in as Status effects. Apparently, the effects are Baton Passable and they do not de-activate when the ability is changed as seen in this replay:
http://replay.pokemonshowdown.com/gen7balancedhackmons-797571348
Turn 29, Darmanitan gets hit with Core Enforcer, but turn 31 Mega Gengar turns Darmanitan's ability to Normalize. Even though Darmanitan had it's ability changed, it was still de-activated. I feel like that is unintuitive because many players don't know that the effect is still up. Throat Chop is pretty uncommon too but that got added in as a status effect...
While this is not a huge problem in many tiers, Core Enforcer is exceptionally common in Balanced Hackmons. I tried implementing Gastro Acid's and Core Enforcer's effects as a bad 'status'. I can't test it for myself to see if it works because I don't know how to. I'd appreciate if you could take a look and perhaps implement (and fix?) this.
I'm unsure how, to be frank. I thought I needed more than what the repository provided.
Regardless, I wanted to contribute to this since I would really appreciate if Gastro Acid/Core Enforcer was a 'bad status', as it would help improve Balanced Hackmons quite a bit.
Did you read the README? It's okay if you didn't. But if you did, which part of it was unclear?
I just changed the README to make it a bit clearer, but this is the old one you would have seen:
https://github.com/Zarel/Pokemon-Showdown-Client/blob/9bf48c904f5c54fd26b01d575e8f93101909b599/README.md
Which part of it made you think you needed more than what the repository provided?
(You don't need anything more, just run node build and double-click testclient.html)
Anyway, your idea of adding a status to the statusTable is solid, and is one of several steps that need to happen for this, but you're just missing a lot of other steps.
The warning segment. I'd like to contribute to add this as a status effect, I'm just not quite sure what else to do now. I may have to look into the code more.
Thanks for the PR but it doesn't seem like this work is ready to merge and it has been a long time since.
Hi, I'd like to apologize. Got caught up in life and eventually after a point I forgot I ever made this pull request. I don't think I'm fit for the job, although I genuinely wanted to help...