Simon André

Results 779 comments of Simon André

I find a bit strange to not differenciate isSubmitted() & isValid() 😐 And when a form is _not_ submitted, any later call to "isValid()" will throw an exception afterwards. Meaning...

> For reference, this same feature was implemented on the controller before #24576 and reverted in #29813. Thank you, very interesting reading! Most convincing arguments (imho): * prefix _is_ should...

Maybe renaming the method `isFormSubmittedAndValid` would better describe what it does ? (Maybe just me, but i feel `isSubmittedForm` imply the form `is` submitted)

Does the notInPath method work for this ? This will be a _big_ BC break, as `->exclude('/var/')` will have a major behaviour change, no ?

Thank you for the detailed answer. I guess adding some functional tests (testing the behaviour with the recursiveiterator) is not a bad idea :)

It has been removed as a fix: https://github.com/symfony/symfony/pull/50819

I used your suggestions / feedbacks and the tests from chessurisme, and ... i'm quite happy with how it looks ![Panda-24](https://github.com/lucide-icons/lucide/assets/1359581/62a150d7-3531-4d6b-a39f-b9417c2e1073) ![Panda-96](https://github.com/lucide-icons/lucide/assets/1359581/7cce719e-1f21-436f-9746-159aa6d23b0b) WDYT ?

I'm walking on eggshells here... no offense intended!! ☮️ I've noticed that some icons seem to have "similar" features to this panda (not a panda matter, I'm just trying to...

@jguddas @karsa-mistmere thank you _very much_ for this patient and detailed explanation ! I've always set lucide with a 1.5 stroke.. so i'm used to see more "space" than in...