Simon André

Results 299 comments of Simon André

... and role="status" on the loaders ( https://getbootstrap.com/docs/5.0/components/spinners/#about )

Yep i was more thinking about the second one, but your 1 is very valid too. Did you look at the Sylmfony HtmlSanitizer source code ? I guess we could...

On this repo i don't _want_ anything :) I don't know enshrined/svg-sanitize i'll take a look thanks! ... and i'm not sure you'll often see me ask for aditional lirbaries...

How would you handle keys that do need quotes ? Keep the quotes only for them ? (seems legit) ``` {{ include('foo.twig', { '123': 123 }) }} {{ include('foo.twig', {...

```diff - {{ include("hello.html.twig") }} + {{ include('hello.html.twig') }} ``` Would love to have this rule! 👍

Well obviously if i forget to type the most important char..... ``` {{ include('foo.twig', { '0123': 123 }) }} ``` So i think you're right: using the Tokenizer::REGEX_NAME should be...

Oh sorry! It's perfect and really usefull to normalize code styles! Tested on a personal project + ux website: all works as expected. 👏

I only tested quickly on a personal project to be honest 🤷 ...

It's not impossible there is no common ground here 🤷