Simon André

```php public function testInvalidFile() { $this->expectException(FileException::class); $this->expectExceptionMessage('The file "original.gif" was not uploaded due to an unknown error.'); $file = new UploadedFile( __DIR__.'/Fixtures/test.gif', 'original.gif', 'image/gif', ); $file->move(__DIR__.'/Fixtures/directory'); } ``` ```diff Testing...

The error message is used as exception message, so it seems to me this code was a failsafe if "something went wrong".

I'm wondering if we can handle this very-specific use case in another way, because your changes make sense and are easier to "read" than this special "no error but an...

Seems perfect to me. @nicolas-grekas ?

> up please ? I really think this is important thank you Sorry, had a lot going on those last weeks .. seems good to me, but my opinion will...

> My only concern is "What if someone use `check --fix` or `fix --fix`. There is multiple solution To me, `fix --fix ` has no point, so i have no...

> Wouldn't be weird to have a fix command which doesn't fix every time and still output errors you have to fix manually ? That does not change really more...

It seems it does not work with Twig components > File is invalid: Unknown "props" tag. > File is invalid: Unexpected "component" tag (expecting > File is invalid: Unexpected token...

I have no _need_ to use the phar one, and that would not shock me if the PHAR version is released without support for external Parser ;)

> For context it was added by @smnandre in symfony/ux ... only on the website (for now) :) --- Regarding the suggestion, did you run it on the Symfony codebase...